fix(gas-limiter): correct bucket cleanup condition #484
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The garbage collection in AddressGasLimiter never removed any buckets because the retain condition
bucket.available <= bucket.capacitywas always true after the refill operation (which usesmin(capacity, available + refill_rate)).Changed condition from
<=to<so that fully refilled buckets (available == capacity) are properly removed during cleanup intervals.