Skip to content

Conversation

@Bilogweb3
Copy link
Contributor

The garbage collection in AddressGasLimiter never removed any buckets because the retain condition bucket.available <= bucket.capacity was always true after the refill operation (which uses min(capacity, available + refill_rate)).

Changed condition from <= to < so that fully refilled buckets (available == capacity) are properly removed during cleanup intervals.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 15, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@haardikk21
Copy link
Collaborator

We do not use the gas limiter on Base and it is on track to be deleted from this codebase. I'm going to close this PR as it doesn't pertain to an issue we're attempting to solve.

@haardikk21 haardikk21 closed this Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants