feat(webkit): add show-fields to the calendar panel and cap the panel width - #838
Open
gabriel-lisboa-azion wants to merge 1 commit into
Open
feat(webkit): add show-fields to the calendar panel and cap the panel width#838gabriel-lisboa-azion wants to merge 1 commit into
gabriel-lisboa-azion wants to merge 1 commit into
Conversation
… width `show-fields: false` suppresses the Start/End date fields, leaving the grid, the presets rail and Apply — the interaction a console wants when shortcuts and the grid are the whole story and typing a boundary by hand is not offered. The panel is content-sized, so its widest child sets its width, and one of those children is the consumer's `#footer` slot: a row of shortcut chips stretched the panel without bound and spread the month grid across it. `max-w-[min(90vw,44rem)]` caps it in rem, so the cap grows with the root font the same way the text does, and 90vw keeps it inside a narrow viewport. Catalog rebuilt for the new prop.
herbert-julio-azion
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
show-fieldsprop toCalendar(defaulttrue) and caps the popover panel width.show-fields: falsesuppresses the Start/End date fields, leaving the grid, the presets rail and Apply. The interaction some consoles want is "pick from shortcuts or click the grid" — typing a boundary by hand is not offered there, and an empty pair of fields is dead weight in the panel.#footerslot. A row of shortcut chips stretched the panel without bound and spread the month grid across it.max-w-[min(90vw,44rem)]is the hard stop:rem(not a px container token) because the content that grows is text, so the cap grows with the root font the same way the grid and the chips do;90vwkeeps it inside a narrow viewport. It sits above every built-in layout, includinghorizontal, so nothing that ships is clipped.Why
Both came out of building a console screen that drives the calendar from shortcut chips in the footer: the fields were redundant there, and the chips blew the panel open.
Surface
+ showFields?: boolean = true.specs/calendar.md— Purpose + Props row, checksum refreshedcatalog.jsonrebuilt (catalog:build) socatalog:checkstays greenTests
Two cases added to
calendar.test.ts:show-fields=falsehidesinput-calendar__fieldswhile keeping the grid and Apply; the default renders the fields. Existing suite unchanged.Note
calendar.vueandcalendar.test.tsare also touched by #827 (fix/calendar-field-parity), which adds neither of these. The two are independent but will conflict textually — whichever lands second rebases.