-
Notifications
You must be signed in to change notification settings - Fork 5
feat(webkit): component fixes batch — Link, TabView, Popover, MiniButton, Dialog, theme #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
a2be257
feat(webkit): add small size to Link, aligning its scale with Button
gabriel-lisboa-azion e527036
fix(webkit): render Popover panel in one teleported subtree, contain …
gabriel-lisboa-azion 27fea84
feat(webkit): make TabView tab bar horizontally scrollable with edge-…
gabriel-lisboa-azion 13ff05e
fix(webkit): scale MiniButton hover ghost and content gap per size
gabriel-lisboa-azion dcde245
fix(theme): deepen popup scale keyframes to 0.9 for a more pronounced…
gabriel-lisboa-azion 3d241ec
fix(webkit): tween Dialog panel via translate/scale properties under …
gabriel-lisboa-azion 25b695d
chore(webkit): update generated catalog.json
gabriel-lisboa-azion c599d17
fix(webkit): widen PopoverContent ref-callback type and refresh tab-v…
herbert-julio-azion 6eaa496
test(webkit): drop TabView overflow/edge-fade assertions from the uni…
herbert-julio-azion d6593b3
test(storybook): regenerate MiniButton, Link, TabView visual baselines
herbert-julio-azion cf61ee4
Merge branch 'main' into worktree-component-fixes-batch
robsongajunior 452e6dd
Merge branch 'main' into worktree-component-fixes-batch
robsongajunior d4051bc
Merge branch 'main' into worktree-component-fixes-batch
robsongajunior ee0f664
refactor(webkit): apply PR #785 review to popover and link spec
gabriel-lisboa-azion 57aa206
Merge branch 'main' into worktree-component-fixes-batch
robsongajunior d3fa576
Merge branch 'main' into worktree-component-fixes-batch
robsongajunior 3c28b68
Merge branch 'main' into worktree-component-fixes-batch
robsongajunior File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-2 Bytes
(100%)
...__image_snapshots__/linux/components-actions-minibutton--sizes--dark-mobile.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-3 Bytes
(100%)
...__image_snapshots__/linux/components-actions-minibutton--sizes--dark-tablet.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4 Bytes
(100%)
...image_snapshots__/linux/components-actions-minibutton--sizes--light-desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4 Bytes
(100%)
..._image_snapshots__/linux/components-actions-minibutton--sizes--light-mobile.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-4 Bytes
(100%)
..._image_snapshots__/linux/components-actions-minibutton--sizes--light-tablet.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-3 Bytes
(100%)
.../test-visual/__image_snapshots__/linux/components-actions-minibutton--sizes.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+96 Bytes
(100%)
...al/__image_snapshots__/linux/components-navigation-link--sizes--dark-mobile.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+99 Bytes
(100%)
...al/__image_snapshots__/linux/components-navigation-link--sizes--dark-tablet.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+126 Bytes
(100%)
.../__image_snapshots__/linux/components-navigation-link--sizes--light-desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+125 Bytes
(100%)
...l/__image_snapshots__/linux/components-navigation-link--sizes--light-mobile.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+126 Bytes
(100%)
...l/__image_snapshots__/linux/components-navigation-link--sizes--light-tablet.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+99 Bytes
(100%)
...ook/test-visual/__image_snapshots__/linux/components-navigation-link--sizes.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+5.62 KB
...ge_snapshots__/linux/components-navigation-tabview--scrollable--dark-mobile.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+6.11 KB
...ge_snapshots__/linux/components-navigation-tabview--scrollable--dark-tablet.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+6.72 KB
..._snapshots__/linux/components-navigation-tabview--scrollable--light-desktop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+5.81 KB
...e_snapshots__/linux/components-navigation-tabview--scrollable--light-mobile.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+6.38 KB
...e_snapshots__/linux/components-navigation-tabview--scrollable--light-tablet.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+6.45 KB
...-visual/__image_snapshots__/linux/components-navigation-tabview--scrollable.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.