Skip to content

fix: prevent password length validation fatal#192

Merged
Helias merged 1 commit into
masterfrom
fix/acore-user-password-validation
Jun 6, 2026
Merged

fix: prevent password length validation fatal#192
Helias merged 1 commit into
masterfrom
fix/acore-user-password-validation

Conversation

@Yehonal

@Yehonal Yehonal commented Jun 1, 2026

Copy link
Copy Markdown
Member

Changes

  • Qualifies the password length constant as \ACore\Manager\UserValidator::PASSWORD_LENGTH during WordPress password validation.
  • Updates the validation message wording while keeping the same 16-character limit.

Why

When a submitted password is longer than the AzerothCore limit, the validator tried to read an unqualified PASSWORD_LENGTH constant. In PHP 8 this can fatal instead of returning a validation error to WordPress.

Testing

  • Passed: git diff --check
  • Not run: php -l, composer tests; php/composer/docker are not installed in this runtime.

@Helias Helias merged commit e48623c into master Jun 6, 2026
1 check passed
@Helias Helias deleted the fix/acore-user-password-validation branch June 6, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants