#28 Add hints for enterprise users regarding rate-limiting/GITHUB_TOKEN#29
#28 Add hints for enterprise users regarding rate-limiting/GITHUB_TOKEN#29axel-op merged 1 commit intoaxel-op:masterfrom
Conversation
|
Thank you for the PR! Please ignore the failing checks. I've made slight modifications to your commit, do you approve them? Also, I'm not sure to understand what you mean by:
|
|
I'm referring to problems arising from working on an on-prem, isolated Github Enterprise instance, and consuming content from Github.com in Actions. In that case, it is not desirable to use a token valid for Github.com for any authentication with the local Github Enterprise instance, as the two are distinct authenticarion realms. It would be impossible to authenticate commits made on an Enterprise Github instance, with the token required to circumvent rate limiting on github.com. That's mostly an Enterprise problem though, hence why I didn't forge ahead to change the wording. Thanks for the nice rewording by the way, changes look good! I wonder whether referring to the problem of (enterprise) proxies also making authorization essentially a prerequisite is worth it - but in general I trust people to extrapolate from the information presented here :) |
|
You may be right 🤔 I'll probably disable the commit authentication using this parameter in a future version. Thank you! Merging this PR right now. |
I'm doubtful that the final sentence of the paragraph is valid for enterprise users either, as the token would either be valid with github.com for authenticating the download calls, or on the Github Enterprise instance, for authenticating the commit.
This addresses #28