Skip to content

Conversation

@lostella
Copy link
Contributor

@lostella lostella commented Jul 6, 2022

Issue #, if available: Fixes #2140

Description of changes: See discussion in #2133

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

@lostella lostella requested review from jaheba and rsnirwan July 6, 2022 15:33
@lostella
Copy link
Contributor Author

lostella commented Jul 6, 2022

Makes me think: we don't have tests that raise the issue on Python 3.9? Are we sure the issue is related to Python 3.9? @rsnirwan @jaheba

@jaheba
Copy link
Contributor

jaheba commented Jul 6, 2022

Looks like this is deliberate: python/cpython#27545

I don't think I agree with that decision.

@lostella lostella merged commit 5e64be7 into awslabs:dev Jul 6, 2022
@lostella lostella deleted the fix-pandas-dataset branch July 6, 2022 16:33
lostella added a commit to lostella/gluonts that referenced this pull request Jul 8, 2022
@lostella lostella mentioned this pull request Jul 8, 2022
lostella added a commit that referenced this pull request Jul 8, 2022
* Docs: Rework `installation` section. (#2130)

* Fix DatasetCollection (#2135)

* Fix `PandasDataset` for Python 3.9 (#2141)

* Docs: Fix running tutorials for publishing docs. (#2138)

* Docs: Fix running tutorials for publishing docs.

* Update requirements.

* Docs: Make notebook templates. (#2122)

* Use of check_github_event.

* Fix issues with hyperparameter tuning tutorial (#2143)

* Apply black to notebooks. (#2144)

Co-authored-by: Jasper <[email protected]>
Co-authored-by: rsnirwan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: PandasDataset() takes no arguments for PandasDataset.from_long_dataframe

2 participants