update backward.h to v1.6 upstream release #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@marcomagdy I've never been deep into this ecosystem :) - Are you aware of any shady side-effects of this blind copy+paste that I should be aware of? |
Contributor
|
This should be fine. However, we don't have a test case that triggers a crash. So add a test or test manually to make sure it still works. |
bmoffatt
commented
Aug 22, 2022
marcomagdy
approved these changes
Aug 22, 2022
Contributor
marcomagdy
left a comment
There was a problem hiding this comment.
LGTM - left one comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Prompted by: #144 (comment)
Description of changes:
Updates backward.h to the most recent tagged release of https://github.com/bombela/backward-cpp/releases - should resolve quirks for folk authoring code on ARM Macs, and re-baselines the feature set
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.