Remove the need to have an S3 bucket to run the tests #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcomagdy
approved these changes
Dec 1, 2021
Contributor
marcomagdy
left a comment
There was a problem hiding this comment.
Thanks. Left a few comments, fix and merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
I wanted to make it easier for other contributors to the the test cases. Right now, anyone who isn't working at Amazon would need to create their own bucket and edit the test case to point at it.
S3 is nice for bypassing Lambda's direct zip upload limits, but I think these test produce zip files well under that limit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.