-
Notifications
You must be signed in to change notification settings - Fork 8
Remove support for Java 11 #615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thx so much @agebhar1 ! nit: diff --git a/README.md b/README.md
index 31c57d8..f79bc1d 100644
--- a/README.md
+++ b/README.md
@@ -61,7 +61,7 @@ ### Java Archive (JAR)
### From Source
The following steps describe how to clone the repo and perform a clean packaging of the connector. Requires Maven and
-Java Development Kit (JDK 11 or later).
+Java Development Kit (JDK 17 or later).
Clone the repo:
@@ -92,7 +92,7 @@ # clone repo
Create JAR artifacts:
```console
-docker run --rm -v $(pwd):/src -w /src -it maven:3-eclipse-temurin-11 \
+docker run --rm -v $(pwd):/src -w /src -it maven:3-eclipse-temurin-17 \
mvn clean package -Drevision=$(git describe --tags --always)Outdated deps (shall we manually bump here instead of waiting for Dependabot?) cc/ @maschnetwork for another look |
e48d107 to
4b70f59
Compare
|
The README.md is fixed - slipped trough my fingers 🙈. The outdated deps on this branch (on my PC): AssertJ 4.0.0-M1 is not GA, it's Milestone 1 so I skip this. Also SLF4J's 2.1.0-alpha1. As long as we support Apache Kafka 3.9.x (Confluent Kafka 7.9.x) we should not switch to Apache Connect API 4.1.0. Fortunately, the API interfaces we use have not changed, as confirmed by the integration tests. |
|
Update to Testcontainers 2.x requires some attention and will follow soon. |
|
@agebhar1 great! Can you please merge your commits into one or two? |
|
Sure @embano1, will do it in the evening. |
Closes aws#613.
* EqualsVerifier from 3.19.4 to 4.2 * JUnit from 5.13.4 to 6.0.0
d0999e1 to
3ab7322
Compare
|
@embano1, I squashed to two commits 'Update to Java 11' and 'Update Dependencies'. Only updated the closed one for 'EqualsVerifier' and 'Junit6' which required some updates. All other dependencies, except Testcontainers 2.0.1' should be able to merge from the Dependabot PRs after merging this one. Dependabot should rebase the PRs if necessary. |
|
@agebhar1 as always, thx a ton! Super helpful! |
Description
Build connector for Java 17 which requires Java 17+ runtime.
Test Steps
Checklist:
Related Issue
#613
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.