Skip to content

Conversation

@agebhar1
Copy link
Contributor

Description

Build connector for Java 17 which requires Java 17+ runtime.

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

#613

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@agebhar1 agebhar1 requested a review from a team as a code owner October 12, 2025 15:37
@embano1
Copy link
Member

embano1 commented Oct 19, 2025

Thx so much @agebhar1 !

nit:

diff --git a/README.md b/README.md
index 31c57d8..f79bc1d 100644
--- a/README.md
+++ b/README.md
@@ -61,7 +61,7 @@ ### Java Archive (JAR)
 ### From Source
 
 The following steps describe how to clone the repo and perform a clean packaging of the connector. Requires Maven and
-Java Development Kit (JDK 11 or later).
+Java Development Kit (JDK 17 or later).
 
 Clone the repo:
 
@@ -92,7 +92,7 @@ # clone repo
 Create JAR artifacts:
 
 ```console
-docker run --rm -v $(pwd):/src -w /src -it maven:3-eclipse-temurin-11 \
+docker run --rm -v $(pwd):/src -w /src -it maven:3-eclipse-temurin-17 \
 mvn clean package -Drevision=$(git describe --tags --always)

Outdated deps (shall we manually bump here instead of waiting for Dependabot?)

mvn versions:display-property-updates -DprocessDependencyManagement=false 
[INFO] The following version properties are referencing the newest available version:
[INFO]   ${com.jayway.jsonpath.version} ................................ 2.9.0
[INFO]   ${commons-logging.version} .................................... 1.3.5
[INFO]   ${joda-time.version} ......................................... 2.14.0
[INFO]   ${org.awaitility.version} ..................................... 4.3.0
[INFO]   ${org.hamcrest.version} ......................................... 3.0
[INFO] The following version property updates are available:
[INFO]   ${aws.java.sdk.version} .......................... 2.31.78 -> 2.35.10
[INFO]   ${ch.qos.logback.version} .......................... 1.5.18 -> 1.5.19
[INFO]   ${com.fasterxml.jackson.version} ................... 2.19.1 -> 2.20.0
[INFO]   ${commons-codec.version} ........................... 1.18.0 -> 1.19.0
[INFO]   ${connect.api.version} ............................... 3.9.1 -> 4.1.0
[INFO]   ${equalsverifier.version} ............................. 3.19.4 -> 4.2
[INFO]   ${net.minidev.json-smart.version} .................... 2.5.2 -> 2.6.0
[INFO]   ${org.apache.commons.version} ...................... 3.18.0 -> 3.19.0
[INFO]   ${org.assertj.version} ........................... 3.27.3 -> 4.0.0-M1
[INFO]   ${org.jacoco.version} .............................. 0.8.13 -> 0.8.14
[INFO]   ${org.junit.jupiter.version} ........................ 5.13.3 -> 6.0.0
[INFO]   ${org.mockito.version} ............................. 5.18.0 -> 5.20.0
[INFO]   ${org.skyscreamer.version} ......................... 1.5.3 -> 2.0-rc1
[INFO]   ${org.slf4j.version} ......................... 2.0.17 -> 2.1.0-alpha1
[INFO]   ${org.testcontainers.version} ....................... 1.21.3 -> 2.0.1

cc/ @maschnetwork for another look

@agebhar1 agebhar1 force-pushed the feature/gh613-java17+ branch from e48d107 to 4b70f59 Compare October 19, 2025 10:19
@agebhar1
Copy link
Contributor Author

The README.md is fixed - slipped trough my fingers 🙈.

The outdated deps on this branch (on my PC):

mvn versions:display-property-updates -DprocessDependencyManagement=false
[INFO] Scanning for projects...
[INFO] 
[INFO] -------------< software.amazon.msk:kafka-eventbridge-sink >-------------
[INFO] Building kafka-eventbridge-sink ${revision}
[INFO]   from pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- versions:2.19.1:display-property-updates (default-cli) @ kafka-eventbridge-sink ---
[INFO] 
[INFO] The following version properties are referencing the newest available version:
[INFO]   ${ch.qos.logback.version} .................................... 1.5.19
[INFO]   ${com.fasterxml.jackson.version} ............................. 2.20.0
[INFO]   ${com.jayway.jsonpath.version} ................................ 2.9.0
[INFO]   ${commons-codec.version} ..................................... 1.19.0
[INFO]   ${commons-logging.version} .................................... 1.3.5
[INFO]   ${equalsverifier.version} ....................................... 4.2
[INFO]   ${joda-time.version} ......................................... 2.14.0
[INFO]   ${net.minidev.json-smart.version} ............................. 2.6.0
[INFO]   ${org.apache.commons.version} ................................ 3.19.0
[INFO]   ${org.awaitility.version} ..................................... 4.3.0
[INFO]   ${org.hamcrest.version} ......................................... 3.0
[INFO]   ${org.mockito.version} ....................................... 5.20.0
[INFO] The following version property updates are available:
[INFO]   ${aws.java.sdk.version} ........................... 2.35.0 -> 2.35.10
[INFO]   ${connect.api.version} ............................... 3.9.1 -> 4.1.0
[INFO]   ${org.assertj.version} ........................... 3.27.6 -> 4.0.0-M1
[INFO]   ${org.jacoco.version} .............................. 0.8.13 -> 0.8.14
[INFO]   ${org.junit.jupiter.version} ........................ 5.13.4 -> 6.0.0
[INFO]   ${org.skyscreamer.version} ......................... 1.5.3 -> 2.0-rc1
[INFO]   ${org.slf4j.version} ......................... 2.0.17 -> 2.1.0-alpha1
[INFO]   ${org.testcontainers.version} ....................... 1.21.3 -> 2.0.1
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.767 s
[INFO] Finished at: 2025-10-19T12:15:41+02:00
[INFO] -----------------------------------------------------------------------

AssertJ 4.0.0-M1 is not GA, it's Milestone 1 so I skip this. Also SLF4J's 2.1.0-alpha1.

As long as we support Apache Kafka 3.9.x (Confluent Kafka 7.9.x) we should not switch to Apache Connect API 4.1.0. Fortunately, the API interfaces we use have not changed, as confirmed by the integration tests.

@agebhar1
Copy link
Contributor Author

Update to Testcontainers 2.x requires some attention and will follow soon.

@embano1
Copy link
Member

embano1 commented Oct 19, 2025

@agebhar1 great! Can you please merge your commits into one or two?

@agebhar1
Copy link
Contributor Author

Sure @embano1, will do it in the evening.

* EqualsVerifier from 3.19.4 to 4.2
* JUnit from 5.13.4 to 6.0.0
@agebhar1 agebhar1 force-pushed the feature/gh613-java17+ branch from d0999e1 to 3ab7322 Compare October 20, 2025 16:38
@agebhar1
Copy link
Contributor Author

@embano1, I squashed to two commits 'Update to Java 11' and 'Update Dependencies'. Only updated the closed one for 'EqualsVerifier' and 'Junit6' which required some updates.

All other dependencies, except Testcontainers 2.0.1' should be able to merge from the Dependabot PRs after merging this one. Dependabot should rebase the PRs if necessary.

@embano1 embano1 enabled auto-merge October 24, 2025 06:07
@embano1
Copy link
Member

embano1 commented Oct 24, 2025

@agebhar1 as always, thx a ton! Super helpful!

@embano1 embano1 added this pull request to the merge queue Oct 24, 2025
Merged via the queue into aws:main with commit b115715 Oct 24, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants