Skip to content

chore(logger): extract logger creation into protected method #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dreamorosi merged 1 commit into from
Aug 2, 2023
Merged

chore(logger): extract logger creation into protected method #1646

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/logger/src/Logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ class Logger extends Utility implements ClassThatLogs {
logFormatter: this.getLogFormatter(),
};
const parentsPowertoolsLogData = this.getPowertoolLogData();
const childLogger = new Logger(
const childLogger = this.createLogger(
merge(parentsOptions, parentsPowertoolsLogData, options)
);

Expand Down Expand Up @@ -554,6 +554,16 @@ class Logger extends Utility implements ClassThatLogs {
this.processLogItem(16, input, extraInput);
}

/**
* Creates a new Logger instance.
*
* @param {ConstructorOptions} [options]
* @returns {Logger}
*/
protected createLogger(options?: ConstructorOptions): Logger {
return new Logger(options);
}

/**
* Decides whether the current log item should be printed or not.
*
Expand Down