chore: replace git clone of aws-sdk-go-v2 with HTTP fetch of individual model files#669
Conversation
a6d74a0 to
0c87352
Compare
…al model files ack-generate previously cloned the entire aws-sdk-go-v2 repository (hundreds of MB) just to read a single <service>.json model file, taking ~2 minutes on a cold cache. This replaces that with a targeted HTTP fetch from GitHub's raw content URL, downloading only the needed model file and caching it locally under ~/.cache/ack-generate/models/<version>/. Cold generation now completes in ~15 seconds; cached runs are near-instant
165c932 to
811880b
Compare
|
/retest |
1 similar comment
|
/retest |
|
/test s3-controller-test |
811880b to
f794fe5
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
retest |
|
/retest |
|
@michaelhtm: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Description of changes:
ack-generatepreviously cloned the entireaws-sdk-go-v2repository(hundreds of MB) just to read a single
<service>.jsonmodel file,taking ~2 minutes on a cold cache. This replaces that with a targeted
HTTP fetch from GitHub's raw content URL, downloading only the needed
model file and caching it locally under
~/.cache/ack-generate/models/<version>/. Cold generation now completesin ~15 seconds; cached runs similarly in ~15 seconds as well (both run ~3 seconds
without
gofmt)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.