Skip to content

feat: add enable-controller-warmup flag#658

Open
a-hilaly wants to merge 1 commit intoaws-controllers-k8s:mainfrom
a-hilaly:warmp-up
Open

feat: add enable-controller-warmup flag#658
a-hilaly wants to merge 1 commit intoaws-controllers-k8s:mainfrom
a-hilaly:warmp-up

Conversation

@a-hilaly
Copy link
Member

Wire EnableWarmup controller-runtime config to CLI flag and helm values.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Wire EnableWarmup controller-runtime config to CLI flag and helm values.
@ack-prow ack-prow bot requested review from jlbutler and michaelhtm January 20, 2026 05:49
@ack-prow
Copy link

ack-prow bot commented Jan 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Jan 20, 2026
@a-hilaly
Copy link
Member Author

needs a runtime release
/hold

@ack-prow ack-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2026
@ack-prow
Copy link

ack-prow bot commented Jan 20, 2026

@a-hilaly: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution a850279 link false /test verify-attribution
s3-olm-test a850279 link false /test s3-olm-test
ecr-controller-test a850279 link true /test ecr-controller-test
acm-controller-test a850279 link true /test acm-controller-test
apigatewayv2-controller-test a850279 link true /test apigatewayv2-controller-test
ec2-controller-test a850279 link true /test ec2-controller-test
iam-controller-test a850279 link true /test iam-controller-test
efs-controller-test a850279 link true /test efs-controller-test
dynamodb-controller-test a850279 link true /test dynamodb-controller-test
eks-controller-test a850279 link true /test eks-controller-test
documentdb-controller-test a850279 link true /test documentdb-controller-test
eventbridge-controller-test a850279 link true /test eventbridge-controller-test
cloudfront-controller-test a850279 link true /test cloudfront-controller-test
pipes-controller-test a850279 link true /test pipes-controller-test
prometheusservice-controller-test a850279 link true /test prometheusservice-controller-test
s3-controller-test a850279 link true /test s3-controller-test
lambda-controller-test a850279 link true /test lambda-controller-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant