chore: Add Kustomization.yaml for crds#651
chore: Add Kustomization.yaml for crds#651kelvin-acosta wants to merge 2 commits intoaws-controllers-k8s:mainfrom
Conversation
This change adds automatic generation of helm/crds/kustomization.yaml to enable Kustomize-based CRD installation in Helm charts. Changes: - Add templates/helm/crds/kustomization.yaml.tpl template - Include service-specific CRDs and common ACK CRDs - Update releaseTemplatePaths to include the new template The generated file lists all CRD resources for easy Kustomize usage, including both service-specific CRDs and the common FieldExport and IAMRoleSelector CRDs from ACK runtime.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kelvin-acosta The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @kelvin-acosta. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of changes:
Currently, the generated helm charts have a crds/ directory which installs CRDs the first time the helm chart is installed. The problem with the CRDs directory is that it is not managed further in the helm lifecycle, for example with upgrade commands. This creates an alternative way to install the crds using kustomize.
I had first opened a PR in aws-controllers-k8s/eks-controller#191 but was redirected to open a PR in this repo instead.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.