Fix unkeyed struct literals in metav1.Time references warnings#592
Fix unkeyed struct literals in metav1.Time references warnings#592rushmash91 wants to merge 1 commit intoaws-controllers-k8s:mainfrom
metav1.Time references warnings#592Conversation
… unkeyed fields warnings
|
/retest |
a-hilaly
left a comment
There was a problem hiding this comment.
Nice, thanks @rushmash91 ! question, are the warnings produced by the compiler (as in go build) or gofmt?
@a-hilaly eg: |
|
/retest |
|
/test ec2-controller-test |
1 similar comment
|
/test ec2-controller-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, knottnt, michaelhtm, rushmash91 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Why? I don't understand how the screenshot proofs that it's the compiler Cc @rushmash91 |
|
/retest |
|
@rushmash91: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues go stale after 180d of inactivity. |
|
Stale issues rot after 60d of inactivity. |
Description of changes:
fixes compiler warnings related to unkeyed field initialization in metav1.Time struct literals throughout the codebase. Updated all instances to explicitly specify the Time field when initializing metav1.Time structs.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.