added stack-id in resource name generation #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbingli
suggested changes
Oct 8, 2020
src/main/java/software/amazon/cloudformation/resource/IdentifierUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/cloudformation/resource/IdentifierUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/cloudformation/resource/IdentifierUtils.java
Outdated
Show resolved
Hide resolved
src/test/java/software/amazon/cloudformation/resource/IdentifierUtilsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/software/amazon/cloudformation/resource/IdentifierUtilsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/software/amazon/cloudformation/resource/IdentifierUtilsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/software/amazon/cloudformation/resource/IdentifierUtilsTest.java
Show resolved
Hide resolved
wbingli
reviewed
Oct 13, 2020
src/test/java/software/amazon/cloudformation/resource/IdentifierUtilsTest.java
Show resolved
Hide resolved
wbingli
reviewed
Oct 13, 2020
src/test/java/software/amazon/cloudformation/resource/IdentifierUtilsTest.java
Outdated
Show resolved
Hide resolved
wbingli
reviewed
Oct 13, 2020
src/test/java/software/amazon/cloudformation/resource/IdentifierUtilsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/software/amazon/cloudformation/resource/IdentifierUtilsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/software/amazon/cloudformation/resource/IdentifierUtilsTest.java
Show resolved
Hide resolved
wbingli
approved these changes
Oct 15, 2020
sungkkim
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #313
Description of changes:
Added method to generate resource name with the following convention:
<StackName>-<ResourceName>-<Hash>StackName could be retrieved from
StackIdor from system tags -> this overload supports both - ifStackIddoes not match arn pattern then method assumes it received clean stack name so it will use it directly;desired resource name:
my-stack-name-rdsdbclusterparametergroup-19ok0k9pebcx6new stack name:
my-stack-name-rdsdbclusterparametergroup-dlo2atz4kirmBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.