metrics refactor to publish in bulk #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbingli
suggested changes
Sep 17, 2020
src/main/java/software/amazon/cloudformation/metrics/MetricsPublisherImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/cloudformation/LambdaWrapper.java
Outdated
Show resolved
Hide resolved
wbingli
reviewed
Sep 18, 2020
wbingli
left a comment
There was a problem hiding this comment.
Look good to me. Is there any test we have verified that moving the metric publish after write the response works?
Contributor
Author
since write response modifies value by reference it does not really affect metrics publishing unless write response has an issues itself; all the unit tests are passing + tested manually with different valid/invalid templates and all look good |
wbingli
approved these changes
Sep 21, 2020
johnttompkins
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
refactoring publishing method: now accepts
MetricDatum; metrics by error code are put together in bulk to avoid throttling possibility;By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.