Fixing Partition assignment #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
johnttompkins
approved these changes
Jul 9, 2020
rjlohan
pushed a commit
to rjlohan/aws-cloudformation-resource-providers-cloudformation
that referenced
this pull request
Jul 9, 2020
One thing to note - the example template represents a stack which may fail deletion on the first pass due to the order in which the `InitialType` and `UpdatedType` are deleted. If this occurs, a second delete will succeed. This version requires the following PRs from the Java Plugin to be published before this can be finalised; * aws-cloudformation/cloudformation-cli-java-plugin#287 * aws-cloudformation/cloudformation-cli-java-plugin#288
wbingli
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: PR #286 was not implemented correctly. This is generated code from a plugin so isn't tested as part of this package currently. Have tested this version against an actual type and it works as intended now.
Description of changes: N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.