Skip to content

Conversation

@wbingli
Copy link

@wbingli wbingli commented Apr 30, 2020

Issue #, if available: N/A

Description of changes:. Release the latest change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@wbingli wbingli requested a review from rjlohan April 30, 2020 17:07
@wbingli
Copy link
Author

wbingli commented Apr 30, 2020

The integration test failure is the reason why we need to release this new version. Need to update the default code gen version to 1.0.4 so the integ test will use the version from this repo instead of pulling 1.0.3 from remote maven repository.

Why the integ test success before?

Before it was successful because the integ test installs the 1.0.3 with the latest code during build, which overrides the remote 1.0.3.

Copy link
Contributor

@ammokhov ammokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting the build fails complaining that some of the ProxyClient methods were not implemented
this is the code from the stubs

      @Override
      public <RequestT extends AwsRequest, ResponseT extends AwsResponse>
      CompletableFuture<ResponseT>
      injectCredentialsAndInvokeV2Async(RequestT request, Function<RequestT, CompletableFuture<ResponseT>> requestFunction) {
        throw new UnsupportedOperationException();
      }

@johnttompkins johnttompkins merged commit 5b8aa01 into aws-cloudformation:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants