Skip to content

removing AsyncClient and assignment in return statement in ClientBuilder #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PatMyron merged 1 commit into from
Apr 30, 2020
Merged

removing AsyncClient and assignment in return statement in ClientBuilder #252

PatMyron merged 1 commit into from
Apr 30, 2020

Conversation

@PatMyron
Copy link
Contributor

@PatMyron PatMyron commented Apr 30, 2020

LambdaWrapper.HTTP_CLIENT is SdkHttpClient, not SdkAsyncHttpClient, so the code needs to be changed one way or the other

ditched Async citing the prior art for AWS::SES::ConfigurationSet and AWS::Logs::LogGroup, but no strong opinion either way

@PatMyron PatMyron changed the title removing assignment in return statement and AsyncClient in ClientBuilder removing AsyncClient and assignment in return statement in ClientBuilder Apr 30, 2020
@PatMyron PatMyron requested a review from miparnisari April 30, 2020 17:44
@PatMyron PatMyron merged commit 0c8cb2b into master Apr 30, 2020
@PatMyron PatMyron deleted the PatMyron-patch-2 branch May 30, 2020 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ammokhov ammokhov ammokhov approved these changes

@johnttompkins johnttompkins Awaiting requested review from johnttompkins

+1 more reviewer

@miparnisari miparnisari miparnisari approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PatMyron @miparnisari @ammokhov