Renaming call chain methods to spell out intent clearly #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjlohan
approved these changes
Apr 22, 2020
Contributor
rjlohan
left a comment
There was a problem hiding this comment.
LGTM. Might be good to also rename call to makeServiceCall?
rjlohan
approved these changes
Apr 22, 2020
aygold92
approved these changes
Apr 22, 2020
Contributor
aygold92
left a comment
There was a problem hiding this comment.
these changes seem fine, I have a few other things I'm wondering if we can change as well. I'm fine if this PR is updated with those or if there is another PR.
- I'm kinda confused about the
progress()method, seems to actually mean something likestillInProgress()but not sure, maybe that can be clarified https://github.com/aws-cloudformation/cloudformation-cli-java-plugin/blob/master/src/main/java/software/amazon/cloudformation/proxy/CallChain.java#L400 - why are there deprecated methods? No production resource is using this, plus we're changing these method names anyway.
ammokhov
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Changing method names to help with understanding intent with the pattern better
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.