[FIX] Passing checks#298
Merged
ArlindKadra merged 27 commits intorefactor_development_regularization_cocktailsfrom Dec 7, 2021
Merged
[FIX] Passing checks#298ArlindKadra merged 27 commits intorefactor_development_regularization_cocktailsfrom
ArlindKadra merged 27 commits intorefactor_development_regularization_cocktailsfrom
Conversation
ravinkohli
commented
Oct 25, 2021
ravinkohli
commented
Oct 25, 2021
ravinkohli
commented
Oct 25, 2021
ravinkohli
commented
Oct 25, 2021
ravinkohli
commented
Oct 25, 2021
ravinkohli
commented
Oct 25, 2021
ravinkohli
commented
Oct 25, 2021
ravinkohli
commented
Oct 25, 2021
test/test_pipeline/components/preprocessing/test_tabular_column_transformer.py
Outdated
Show resolved
Hide resolved
Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com>
nabenabe0928
requested changes
Nov 4, 2021
nabenabe0928
reviewed
Nov 4, 2021
nabenabe0928
reviewed
Nov 8, 2021
Collaborator
nabenabe0928
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments.
I noticed that my comments was not completed properly, so I added comments.
nabenabe0928
reviewed
Nov 8, 2021
ArlindKadra
reviewed
Nov 8, 2021
ArlindKadra
reviewed
Dec 6, 2021
ArlindKadra
left a comment
There was a problem hiding this comment.
Looks good, although I have a few uncertainties :)
autoPyTorch/pipeline/components/setup/network_backbone/InceptionTimeBackbone.py
Show resolved
Hide resolved
ArlindKadra
reviewed
Dec 6, 2021
| assert np.shape(input_data_featuretest) == np.shape(transformed_X) | ||
| categories_ = validator.column_transformer.\ | ||
| named_transformers_['categorical_pipeline'].named_steps['onehotencoder'].categories_ | ||
| assert any(('0' in categories) or (0 in categories) or ('missing_value' in categories) for categories in |
There was a problem hiding this comment.
This are the unique category values for the one hot encoder right, what would be the case where they are 0?
Is it not 'missing_value' for categorical columns?
Contributor
Author
There was a problem hiding this comment.
it will be 0 when the column is categorical but the dtype of the column is int
There was a problem hiding this comment.
according to this
Auto-PyTorch/autoPyTorch/data/tabular_feature_validator.py
Lines 380 to 381 in 10aea66
It will be a categorical column only when it has a string or bool dtype.
And if between test and train there are differences, it will either throw an error or convert a null column to object for test if not empty in train.
There was a problem hiding this comment.
Does it fail if you run it without the 0 checks?
Contributor
Author
There was a problem hiding this comment.
It will be a categorical column only when it has a
stringorbooldtype
not string, but category. And category can be string or int.
Contributor
Author
There was a problem hiding this comment.
It works fine without '0' check but removing 0 gives an error
ravinkohli
added a commit
that referenced
this pull request
Dec 8, 2021
* Initial fix for all tests passing locally py=3.8 * fix bug in tests * fix bug in test for data * debugging error in dummy forward pass * debug try -2 * catch runtime error in ci * catch runtime error in ci * add better debug test setup * debug some more * run this test only * remove sum backward * remove inplace in inception block * undo silly change * Enable all tests * fix flake * fix bug in test setup * remove anamoly detection * minor changes to comments * Apply suggestions from code review Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com> * Address comments from Shuhei * revert change leading to bug * fix flake * change comment position in feature validator * Add documentation for _is_datasets_consistent * address comments from arlind * case when all nans in test Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com>
ravinkohli
added a commit
that referenced
this pull request
Dec 8, 2021
* Initial fix for all tests passing locally py=3.8 * fix bug in tests * fix bug in test for data * debugging error in dummy forward pass * debug try -2 * catch runtime error in ci * catch runtime error in ci * add better debug test setup * debug some more * run this test only * remove sum backward * remove inplace in inception block * undo silly change * Enable all tests * fix flake * fix bug in test setup * remove anamoly detection * minor changes to comments * Apply suggestions from code review Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com> * Address comments from Shuhei * revert change leading to bug * fix flake * change comment position in feature validator * Add documentation for _is_datasets_consistent * address comments from arlind * case when all nans in test Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com>
ravinkohli
added a commit
that referenced
this pull request
Dec 21, 2021
* Initial fix for all tests passing locally py=3.8 * fix bug in tests * fix bug in test for data * debugging error in dummy forward pass * debug try -2 * catch runtime error in ci * catch runtime error in ci * add better debug test setup * debug some more * run this test only * remove sum backward * remove inplace in inception block * undo silly change * Enable all tests * fix flake * fix bug in test setup * remove anamoly detection * minor changes to comments * Apply suggestions from code review Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com> * Address comments from Shuhei * revert change leading to bug * fix flake * change comment position in feature validator * Add documentation for _is_datasets_consistent * address comments from arlind * case when all nans in test Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com>
ravinkohli
added a commit
that referenced
this pull request
Jan 24, 2022
* Initial fix for all tests passing locally py=3.8 * fix bug in tests * fix bug in test for data * debugging error in dummy forward pass * debug try -2 * catch runtime error in ci * catch runtime error in ci * add better debug test setup * debug some more * run this test only * remove sum backward * remove inplace in inception block * undo silly change * Enable all tests * fix flake * fix bug in test setup * remove anamoly detection * minor changes to comments * Apply suggestions from code review Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com> * Address comments from Shuhei * revert change leading to bug * fix flake * change comment position in feature validator * Add documentation for _is_datasets_consistent * address comments from arlind * case when all nans in test Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com>
ravinkohli
added a commit
that referenced
this pull request
Jan 28, 2022
* Initial fix for all tests passing locally py=3.8 * fix bug in tests * fix bug in test for data * debugging error in dummy forward pass * debug try -2 * catch runtime error in ci * catch runtime error in ci * add better debug test setup * debug some more * run this test only * remove sum backward * remove inplace in inception block * undo silly change * Enable all tests * fix flake * fix bug in test setup * remove anamoly detection * minor changes to comments * Apply suggestions from code review Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com> * Address comments from Shuhei * revert change leading to bug * fix flake * change comment position in feature validator * Add documentation for _is_datasets_consistent * address comments from arlind * case when all nans in test Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com>
ravinkohli
added a commit
that referenced
this pull request
Feb 28, 2022
* Initial fix for all tests passing locally py=3.8 * fix bug in tests * fix bug in test for data * debugging error in dummy forward pass * debug try -2 * catch runtime error in ci * catch runtime error in ci * add better debug test setup * debug some more * run this test only * remove sum backward * remove inplace in inception block * undo silly change * Enable all tests * fix flake * fix bug in test setup * remove anamoly detection * minor changes to comments * Apply suggestions from code review Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com> * Address comments from Shuhei * revert change leading to bug * fix flake * change comment position in feature validator * Add documentation for _is_datasets_consistent * address comments from arlind * case when all nans in test Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com>
ravinkohli
added a commit
that referenced
this pull request
Feb 28, 2022
* Initial fix for all tests passing locally py=3.8 * fix bug in tests * fix bug in test for data * debugging error in dummy forward pass * debug try -2 * catch runtime error in ci * catch runtime error in ci * add better debug test setup * debug some more * run this test only * remove sum backward * remove inplace in inception block * undo silly change * Enable all tests * fix flake * fix bug in test setup * remove anamoly detection * minor changes to comments * Apply suggestions from code review Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com> * Address comments from Shuhei * revert change leading to bug * fix flake * change comment position in feature validator * Add documentation for _is_datasets_consistent * address comments from arlind * case when all nans in test Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com>
ravinkohli
added a commit
that referenced
this pull request
Mar 9, 2022
* Initial fix for all tests passing locally py=3.8 * fix bug in tests * fix bug in test for data * debugging error in dummy forward pass * debug try -2 * catch runtime error in ci * catch runtime error in ci * add better debug test setup * debug some more * run this test only * remove sum backward * remove inplace in inception block * undo silly change * Enable all tests * fix flake * fix bug in test setup * remove anamoly detection * minor changes to comments * Apply suggestions from code review Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com> * Address comments from Shuhei * revert change leading to bug * fix flake * change comment position in feature validator * Add documentation for _is_datasets_consistent * address comments from arlind * case when all nans in test Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com>
ravinkohli
added a commit
to ravinkohli/Auto-PyTorch
that referenced
this pull request
Apr 12, 2022
* Initial fix for all tests passing locally py=3.8 * fix bug in tests * fix bug in test for data * debugging error in dummy forward pass * debug try -2 * catch runtime error in ci * catch runtime error in ci * add better debug test setup * debug some more * run this test only * remove sum backward * remove inplace in inception block * undo silly change * Enable all tests * fix flake * fix bug in test setup * remove anamoly detection * minor changes to comments * Apply suggestions from code review Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com> * Address comments from Shuhei * revert change leading to bug * fix flake * change comment position in feature validator * Add documentation for _is_datasets_consistent * address comments from arlind * case when all nans in test Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com>
ravinkohli
added a commit
that referenced
this pull request
Jul 26, 2022
* Initial fix for all tests passing locally py=3.8 * fix bug in tests * fix bug in test for data * debugging error in dummy forward pass * debug try -2 * catch runtime error in ci * catch runtime error in ci * add better debug test setup * debug some more * run this test only * remove sum backward * remove inplace in inception block * undo silly change * Enable all tests * fix flake * fix bug in test setup * remove anamoly detection * minor changes to comments * Apply suggestions from code review Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com> * Address comments from Shuhei * revert change leading to bug * fix flake * change comment position in feature validator * Add documentation for _is_datasets_consistent * address comments from arlind * case when all nans in test Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following
The goal of this PR is to pass all checks for the reg_cocktails branch.