factor-bundle cannot be located by Browserify when using common option

[eggyal]

When invoking with common: true, Browserify is unable to find factor-bundle (being a dependency of atomify-js, it's amongst its parent's node_modules and therefore cannot be resolved):

Error: Cannot find module 'factor-bundle' from '/path/to/project'
    at Function.module.exports (/path/to/project/node_modules/atomify/node_modules/atomify-js/node_modules/browserify/node_modules/resolve/lib/sync.js:33:11)
    at Browserify.plugin (/path/to/project/node_modules/atomify/node_modules/atomify-js/node_modules/browserify/index.js:291:29)
    at atomifyJs (/path/to/project/node_modules/atomify/node_modules/atomify-js/index.js:224:7)
...

$ find /path/to/project/node_modules -name factor-bundle
/path/to/project/node_modules/atomify/node_modules/atomify-js/node_modules/.bin/factor-bundle
/path/to/project/node_modules/atomify/node_modules/atomify-js/node_modules/factor-bundle

[joeybaker]

hmmm… that's interesting. Can you share your atomify config/cli command @eggyal?

[eggyal]

I am invoking gulp js with the following Gulpfile.js:

'use strict';

var gulp       = require('gulp'),
    gutil      = requite('gulp-util'),
    livereload = require('gulp-livereload'),
    ajs        = require('atomify').js;

function string_src(filename, string) {
    var src = require('stream').Readable({ objectMode: true });
    src._read = function () {
        this.push(new gutil.File({
            cwd     : "",
            base    : "",
            path    : filename,
            contents: new Buffer(string)
        }));
        this.push(null)
    }
    return src;
}

gulp.task('js', function () {
    var dir = './web/js/';

    ajs.emitter.on('entry', function(content, bundleName) {
        return string_src(bundleName, content)
                 .pipe(gulp.dest(dir))
                 .pipe(livereload());
    });

    return ajs({
        entries: [
            './app/js/test1.js',
            './app/js/test2.js'
        ],
        common : true,
        debug  : true,
        minify : false,
        watch  : true,
        assets : {
            dest  : "./web/assets",
            prefix: "assets/"
        }
    }).pipe(gulp.dest(dir))
      .pipe(livereload());
});

[joeybaker]

hmmm… okay. @eggyal can you try this branch and see if it fixes things for you? https://github.com/atomify/atomify-js/tree/directlyRequireFactorBundle

[eggyal]

Afraid not—

path.js:439
throw new TypeError('Arguments to path.resolve must be strings');

[joeybaker]

Hmmm… can you give me the full stack trace there?

[eggyal]

Oh, that error was just because the stream returned by atomic-js isn't a vinyl file. Once piped through vinyl-source-stream, it's all okay—your fix above did indeed work.

[joeybaker]

Okay! Great. I'll push it through.

[joeybaker]

Published in 4.7.2