Skip to content
This repository was archived by the owner on Apr 6, 2018. It is now read-only.

Add visual feedback for search command ('/','?')#812

Merged
maxbrunsfeld merged 1 commit into
atom:masterfrom
po1o:master
Aug 15, 2015
Merged

Add visual feedback for search command ('/','?')#812
maxbrunsfeld merged 1 commit into
atom:masterfrom
po1o:master

Conversation

@po1o
Copy link
Copy Markdown
Contributor

@po1o po1o commented Aug 2, 2015

When doing a search, display the command '/' or '?' instead of
nothing. This gives the user a visual feedback about what he is
doing.
This is achieved by adding dynamically some classes to the
element container. The CSS class selectors associated display
a content ('/' or '?') before the container.

When doing a search, display the command '/' or '?' instead of
nothing. This gives the user a visual feedback about what he is
doing.
This is achieved by adding dynamically some classes to the
element container. The CSS class selectors associated display
a content ('/' or '?') before the container.
@maxbrunsfeld
Copy link
Copy Markdown
Contributor

Interesting solution! Can you post screenshots or GIFs?

@po1o
Copy link
Copy Markdown
Contributor Author

po1o commented Aug 15, 2015

vim-mode

@maxbrunsfeld
Copy link
Copy Markdown
Contributor

I love it. Thanks!

maxbrunsfeld pushed a commit that referenced this pull request Aug 15, 2015
Add visual feedback for search command ('/','?')
@maxbrunsfeld maxbrunsfeld merged commit 9671371 into atom:master Aug 15, 2015
jacekkopecky added a commit to jacekkopecky/vim-mode that referenced this pull request Aug 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants