This repository was archived by the owner on Apr 6, 2018. It is now read-only.
Canceling c operator#774
Merged
Merged
Conversation
Merged
1693cc6 to
1b88c5a
Compare
Contributor
|
Great! |
t9md
added a commit
to t9md/vim-mode
that referenced
this pull request
Sep 8, 2015
Spec would be updated on atom#774 merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a motion matches nothing, e.g.
%on a line without brackets, orfxon a line without x,cshould be cancelled and go into command mode; currently it simply behaves likei.This PR implements the desired behaviour.
Also, this PR adds a lot of tests for
c%; I wrote those when I mistakenly thought there was some other problem there so I wanted to document the desired behaviour and fix it, and then I found it already worked as I'd described it. If the tests are undesirable, I can remove them.