Skip to content
This repository was archived by the owner on Apr 6, 2018. It is now read-only.

Fix: Prevent ":not([mini])" commands from being fired in search-mode#595

Merged
maxbrunsfeld merged 1 commit into
atom:masterfrom
andischerer:fix-not-mini-commands-searchmode
Mar 30, 2015
Merged

Fix: Prevent ":not([mini])" commands from being fired in search-mode#595
maxbrunsfeld merged 1 commit into
atom:masterfrom
andischerer:fix-not-mini-commands-searchmode

Conversation

@andischerer
Copy link
Copy Markdown
Contributor

Since pr #582 commands with :not([mini]) filter in command definition get fired in search-mode editor in case of a missing mini attribute in the atom-text-editor element.

The way how the editor-view was created in the bottom panel has changed from:

new TextEditorView(mini: true)

to:

@editorElement = document.createElement "atom-text-editor"
@editorElement.classList.add('editor')
@editorElement.getModel().setMini(true)

The setMini setter only sets the mini attribute in the model not in the editor-view.

@maxbrunsfeld
Copy link
Copy Markdown
Contributor

Thanks a lot for catching that!

maxbrunsfeld pushed a commit that referenced this pull request Mar 30, 2015
…mode

Fix: Prevent ":not([mini])" commands from being fired in search-mode
@maxbrunsfeld maxbrunsfeld merged commit 880026d into atom:master Mar 30, 2015
MarkusSN pushed a commit to MarkusSN/vim-mode that referenced this pull request May 28, 2015
…archmode

Fix: Prevent ":not([mini])" commands from being fired in search-mode
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants