:feature: show submode in status bar

[jacekkopecky]

This is a suggestion that we may want to show the submode in the status bar; the PR already includes values for replace mode, proposed in #573.

[maxbrunsfeld]

I like it; nice solution. Nitpicks:

• I'd rather use . as the delimiter than $. It would just mean we'd have to quote the keys.
• I think you could avoid depending on the order of ContentsByMode if you did this:

currentMode = currentMode + "." + currentSubmode if currentSubmode?
for mode, [klass, html] of ContentsByMode
  if mode is currentMode
    # ...  

[jacekkopecky]

Thank you.
I've committed a fix in 91069db so the code doesn't rely on order, keeping the ability to match only on the mode. If we don't keep currentFullMode we'd have to enumerate all submodes in ContentsByMode.
Which alternative would you prefer?

[maxbrunsfeld]

Oh, I see what you're saying. I think the most straightforward thing to do is to use the code snippet I wrote above; we just need to enumerate all possible combinations of mode and submode in ContentsByMode, rather than abbreviating visual.characterwise as visual.

I don't think we can use a break statement like you have on line 30, because it could incorrectly prevent classes from being removed from the @element div.

[jacekkopecky]

You're right, I missed that. OK, enumeration it is; the longer I've thought about it the better this option has sounded anyway. Commit coming soon.

[jacekkopecky]

And I still can't get it as simple as you suggested, @maxbrunsfeld :
Since multiple entries in ContentsByMode share the same class name, there was a risk that a later entry with the same class name but not a matching mode would remove the class set by a preceding entry with a matching mode. In other words, in visual.characterwise, the @element would not have the class status-bar-vim-mode-visual because visual.blockwise would remove it.
So 5490b33 does things differently still. Comments welcome.

[jacekkopecky]

Thanks! 8-)