🐛 Fix broken test cases#386
Conversation
These test cases were not running due to indentation errors. The tests for commands 'dj' and 'dk' now correctly fail.
|
Would you mind merging/rebasing master into this branch so the specs run again on Travis with the fix from bc178f2 ? |
These test cases were not running due to indentation errors. The tests for commands 'dj' and 'dk' now correctly fail.
|
Okay, the branch has been rebased. Please note, the tests are supposed to fail, as the functionality is broken. This pull request was just to fix the fact that the tests weren't running at all because of syntax errors. |
These test cases were not running due to indentation errors. The tests for commands 'dj' and 'dk' now correctly fail.
|
Looks like this issue has been completely fixed. It's easier to see the changes if whitespace is ignored: https://github.com/atom/vim-mode/pull/386/files?w=1 |
|
@sknoslo Thanks so much for noticing this; these tests were indeed totally broken. I've merged your fixes and then adapted most of the tests so that they pass now. We can always adjust the assertions if we want to change vim-mode's behavior to match vim's more exactly. One of the tests I had to mark pending because it checks for a vim behavior that we currently don't match at all ( |
These test cases were not running due to indentation errors.
The tests for commands 'dj' and 'dk' now correctly fail.