Skip to content
This repository was archived by the owner on Apr 6, 2018. It is now read-only.

🐛 Fix broken test cases#386

Merged
maxbrunsfeld merged 9 commits into
atom:masterfrom
sknoslo:fix-specs
Jul 7, 2015
Merged

🐛 Fix broken test cases#386
maxbrunsfeld merged 9 commits into
atom:masterfrom
sknoslo:fix-specs

Conversation

@sknoslo
Copy link
Copy Markdown
Contributor

@sknoslo sknoslo commented Aug 20, 2014

These test cases were not running due to indentation errors.
The tests for commands 'dj' and 'dk' now correctly fail.

These test cases were not running due to indentation errors.
The tests for commands 'dj' and 'dk' now correctly fail.
@kevinsawicki
Copy link
Copy Markdown
Contributor

Would you mind merging/rebasing master into this branch so the specs run again on Travis with the fix from bc178f2 ?

sknoslo and others added 3 commits September 2, 2014 12:30
These test cases were not running due to indentation errors.
The tests for commands 'dj' and 'dk' now correctly fail.
@sknoslo
Copy link
Copy Markdown
Contributor Author

sknoslo commented Sep 2, 2014

Okay, the branch has been rebased. Please note, the tests are supposed to fail, as the functionality is broken. This pull request was just to fix the fact that the tests weren't running at all because of syntax errors.

sknoslo added 4 commits April 30, 2015 13:24
These test cases were not running due to indentation errors.
The tests for commands 'dj' and 'dk' now correctly fail.
@bronson
Copy link
Copy Markdown
Contributor

bronson commented Jul 4, 2015

Looks like this issue has been completely fixed.

It's easier to see the changes if whitespace is ignored: https://github.com/atom/vim-mode/pull/386/files?w=1

@maxbrunsfeld maxbrunsfeld merged commit 8ae62f8 into atom:master Jul 7, 2015
@maxbrunsfeld
Copy link
Copy Markdown
Contributor

@sknoslo Thanks so much for noticing this; these tests were indeed totally broken. I've merged your fixes and then adapted most of the tests so that they pass now. We can always adjust the assertions if we want to change vim-mode's behavior to match vim's more exactly. One of the tests I had to mark pending because it checks for a vim behavior that we currently don't match at all (dk on the first line of the file).

@sknoslo sknoslo deleted the fix-specs branch July 7, 2015 19:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants