This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Rework history to make invariants easier to enfore#81
Merged
Conversation
Signed-off-by: Nathan Sobo <nathan@github.com>
For now, we need this private API because vim-mode uses it for repeating insertion operations. Someday we should add a real public API for this.
maxbrunsfeld
pushed a commit
that referenced
this pull request
Jul 10, 2015
Rework history to make invariants easier to enfore
maxbrunsfeld
added a commit
to atom/vim-mode
that referenced
this pull request
Jul 24, 2015
As of atom/text-buffer#81, which will ship in Atom v1.0.3, the editor's history API has changed in some subtle ways in order to preserve the proper nesting of transactions. The `groupChangesSinceCheckpoint` method no longer works if called from within a transaction with a checkpoint that was created *outside* the transaction. /cc @jacekkopecky, can you double check that this alternative approach works correctly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs atom/atom#7352
Refs atom/atom#7678