Separate markup styles from gfm

[burodepeper]

While making language-markdown as compatible as possible with current syntax themes, I noticed that some styling defined specific for source.gfm might be better off as part of the general .markup class.

I believe this change doesn't break anything, but might perhaps add some extra styling to documents that use the generic markup class. If you agree on this change, I think this should be changed in all default syntax themes. I used one-dark-syntax merely as an example.

One thing that I'm not 100% sure of, is the disabling of the .markup .list style. In my implementation of Markdown, .list is used to describe an entire list-item, instead of just the .list .variable that is actually meant to be targeted in the original.

[simurai]

I think it's a good idea to make it more general and not only for .gfm.

https://github.com/atom/apm/blob/master/templates/theme/styles/base.less is also a good place to change it. It's the styles that get used when generating a new syntax theme in Atom.

[burodepeper]

Agreed.

Could you update the default syntax themes? (I think they all 'suffer' from this 'issue')
Then I'll take a jab at the template in apm in the morning.

[thomasjo]

🔥 Remove commented out lines

[thomasjo]

Nest this block inside the &.heading { .. } block above? Thus resulting in

&.heading {
  color: @hue-5;

  .punctuation.definition.heading {
    color: @hue-2;
  }
}

[thomasjo]

Now that my line comments have been resolved, this looks good to me! /cc @atom/feedback

[burodepeper]

NOTE: changes need to be made to other default templates as well, but I'd like to leave that up to somebody who already has all eight (?) of them forked...

[simurai]

This seems not to be needed, since those "list variables" already get styled as stand alone .variables.

I think the whole

.list {
  .variable {
    color: @hue-5;
  }
}

can be removed.

[burodepeper]

@simurai was right, and I removed the obsolete selector.

[simurai]

Looks.. good. I'll try to update all the other core themes as well.

[burodepeper]

👍