This repository was archived by the owner on Oct 19, 2018. It is now read-only.
Create the GrammarStatusView. Pull out of status bar#2
Merged
Conversation
benogle
added a commit
that referenced
this pull request
Nov 20, 2013
Create the GrammarStatusView. Pull out of status bar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the status-bar api to add the selector link to the status bar. This seems to be the first time one package is reliant on another package. Couple things:
I dont like the method of waiting for the status bar.
The grammar selector could be activated before the status bar. So I have this:
Would be nice to put something in the package manager or the root view to make this easier. The status-bar can put it in the rootView? Not sure what that looks like yet.
Testing the addition to the status bar
I cant load the status-bar package from the specs (though it will load the language grammars, so maybe something else is going on??). So I am mocking the status bar. Not a huge amount of code, but it would be nice to use the real one in case of api or behavior changes. How do you guys feel about using the real package vs using a mock??