After staging file via core:confirm, show the next diff#970
After staging file via core:confirm, show the next diff#970jasonrudolph wants to merge 1 commit intomasterfrom
Conversation
|
👍 I'm in favor of having this the default behaviour. The only thing that feels a bit jarring: After staging a file, the diff view closes and a new diff view opens for the next file. Would it be possible to keep the same pane open and "re-use" it? A short delay until the diff shows up should be ok, as long as the tab and pane stays. |
|
@jasonrudolph thanks so much for this PR. I'm totally onboard with this UX change 👍 I've picked up from where you've left off, to handle other cases (such as staging/unstaging via mouse click) and making it such that we don't close the diff before displaying the next one (as @simurai mentioned). I also made it such that if the user closes the diff view, then we don't open a new diff view when a new file is selected (see below). What I have so far is still super WIP. I'll pick it up and push it forward next week. Appreciate your input! |

Description of the Change
As requested in #854, when you have multiple files present in the staging view, hitting enter stages the file and shows the diff for the next file in the list. See before-and-after demo below.
Alternate Designs
I didn't consider any other designs at this point. For now, I'm opening this PR to get some initial feedback on whether other people appreciate this UX change as much as I do. 😇
Benefits
Streamlined workflow for people using keyboard to stage/unstage multiple files in succession.
Possible Drawbacks
I'm not aware of any.
Applicable Issues
Currently: #864
Previously: #854, #645
Demo
Before
After