This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Fix bad jump to file in reviews controller#2334
Merged
smashwilson merged 2 commits intoatom:masterfrom Nov 7, 2019
Merged
Conversation
This was referenced Jan 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@smashwilson @lkashef @darangi
Fixes #2330
This was possibly overlooked during project management #2308, but now jumping to files uses an absolute path rather than a relative. This may have worked before because github's active context (chosen by active pane) and atom were probably assuming the same directory.