This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1922 +/- ##
==========================================
+ Coverage 92.1% 92.12% +0.01%
==========================================
Files 189 189
Lines 10783 10809 +26
Branches 1580 1581 +1
==========================================
+ Hits 9932 9958 +26
Misses 851 851
Continue to review full report at Codecov.
|
Mostly copy and paste, like the implementations :thinking-face:
annthurium
approved these changes
Jan 28, 2019
annthurium
left a comment
There was a problem hiding this comment.
very cool, this will be super useful to our users.
Does this gracefully fall back if a user was somehow using an older version of find-and-replace?
| this.hasTerminatedPendingState = false; | ||
| this.refInitialFocus = new RefHolder(); | ||
|
|
||
| this.refEditor = new RefHolder(); |
There was a problem hiding this comment.
I see what you mean about cleaning up our items so they aren't so repetitive.
Contributor
Author
Yup, both ways 👍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Requirements
Description of the Change
Implement the
observeEmbeddedTextEditor()protocol established in atom/find-and-replace#1069 (released in find-and-replace@0.218.0) to support the "find" dialog in diff editors.Screenshot/Gif
Alternate Designs
N/A
Benefits
Large diffs become much more useful when you can find changes within them.
Possible Drawbacks
Attempting to trigger a "replace" causes a stacktrace in the console presently, because our TextEditors are read-only. I'd rather fix this in find-and-replace by disabling the replace controls though.
Applicable Issues
In concert with atom/find-and-replace#1069.
Metrics
N/A
Tests
Documentation
N/A
Release Notes
User Experience Research (Optional)
N/A