This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Test coverage for GitShellOutStrategy#1900
Merged
smashwilson merged 18 commits intomasterfrom Jan 12, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1900 +/- ##
==========================================
+ Coverage 91.09% 91.64% +0.54%
==========================================
Files 185 185
Lines 10719 10672 -47
Branches 1575 1563 -12
==========================================
+ Hits 9765 9780 +15
+ Misses 954 892 -62
Continue to review full report at Codecov.
|
cf6aeab to
4860e97
Compare
Contributor
Author
|
And 100% coverage for |
4 tasks
annthurium
approved these changes
Jan 11, 2019
| * ([^\\\\/]*)[\\\\/] captures non-slash characters before first slash | ||
| */ | ||
| const EXPAND_TILDE_REGEX = new RegExp('^~([^/]*)/'); | ||
| const EXPAND_TILDE_REGEX = new RegExp('^~([^\\\\/]*)[\\\\/]'); |
There was a problem hiding this comment.
it's so much more...expandy! (I really wanted to come up with a better joke about this but couldn't.)
| mergeTrailers(commitMessage, trailers, unfold) { | ||
| mergeTrailers(commitMessage, trailers) { | ||
| const args = ['interpret-trailers']; | ||
| if (unfold) { |
| it('propagates unexpected git errors', async function() { | ||
| const workingDirPath = await cloneRepository('three-files'); | ||
| const git = createTestStrategy(workingDirPath); | ||
| sinon.stub(git, 'exec').rejects(new Error('AHHHH')); |
There was a problem hiding this comment.
a+ fake error names in this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Requirements
Description of the Change
This adds unit tests to
git-strategies.test.jsto cover the remaining uncovered lines reported by CodeCov.Alternate Designs
N/A
Benefits
GitShellOutStrategy is one of the more prevalent culprits in test coverage flapping that we see on unrelated PRs. This is one step toward minimizing those changes and keeping CodeCov output relavent.
Possible Drawbacks
N/A
Applicable Issues
N/A
Metrics
N/A
Tests
Ideally this should raise GitShellOutStrategy's coverage to 100%.
Documentation
N/A
Release Notes
N/A
User Experience Research (Optional)
N/A