Upgrade to the latest react and react-dom#1884
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1884 +/- ##
==========================================
+ Coverage 91.22% 91.24% +0.01%
==========================================
Files 196 196
Lines 10745 10745
Branches 1574 1574
==========================================
+ Hits 9802 9804 +2
+ Misses 943 941 -2
Continue to review full report at Codecov.
|
|
Oh, right, this probably needs #1885. |
annthurium
left a comment
There was a problem hiding this comment.
do we need to do any manual testing? Or are you pretty confident that the newest versions of these libs aren't gonna break anything??
also, is this the version with hooks??
For React, yeah, I was going to at least take it for a spin and make sure it runs. Our tests should catch anything that regressed, but just to be sure.
lol |
|
I fired it up and clicking around a bit and it looks like we're still good 👌 |
annthurium
left a comment
There was a problem hiding this comment.
cool, let's ship it! Thanks for doing the manual testing.

Now that atom/electron-link#15 is out, we should be able to update to the latest React builds without hitting weird snapshotting errors or silently falling back to ancient browser shims.
Fixes #1832.