revert misuse of programmatical approach in setup.py#1303
Merged
gonchik merged 1 commit intoatlassian-api:masterfrom Jan 17, 2024
Merged
revert misuse of programmatical approach in setup.py#1303gonchik merged 1 commit intoatlassian-api:masterfrom
gonchik merged 1 commit intoatlassian-api:masterfrom
Conversation
This was referenced Jan 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1303 +/- ##
=======================================
Coverage 34.49% 34.49%
=======================================
Files 45 45
Lines 8257 8257
Branches 1146 1146
=======================================
Hits 2848 2848
Misses 5295 5295
Partials 114 114 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup.pywas ditched a long time ago and newer PEPs recommend usingsetup.cfgorpyproject.tomlThe last changes in
setup.pycreated a misdirected dependency betweenrequirements.txtandsetup.py, which included an optional dependency that is causing problems upstreams.This PR merely reverts those changes in favour for the old already-working setup.