Skip to content

add Sync constraint for RwLock to prevent memory unsafety #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Nov 8, 2019
Merged

add Sync constraint for RwLock to prevent memory unsafety #479

1 commit merged into from
Nov 8, 2019

Conversation

@laizy
Copy link
Contributor

@laizy laizy commented Nov 8, 2019

without Sync constraint, interior mutability data T can be modified concurrently by multiple threads using RwLock.read().await

ghost
ghost approved these changes Nov 8, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good catch, thank you!

@ghost ghost merged commit fb19ebd into async-rs:master Nov 8, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@laizy