Skip to content

Add Write::write_fmt#311

Merged
yoshuawuyts merged 5 commits intomasterfrom
missing-write-methods
Oct 13, 2019
Merged

Add Write::write_fmt#311
yoshuawuyts merged 5 commits intomasterfrom
missing-write-methods

Conversation

@yoshuawuyts
Copy link
Copy Markdown
Contributor

Implements Write::write_fmt. Ref #245. Ref #131.

Also added write and writeln macros to the root as re-exports from std because they work out of the box!

Figured this would be good enough, and we don't need to implement fmt (closes #247). Thanks!

Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
@yoshuawuyts yoshuawuyts added the enhancement New feature or request label Oct 12, 2019
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
@yoshuawuyts yoshuawuyts force-pushed the missing-write-methods branch 2 times, most recently from 4f055ee to f3eba1f Compare October 12, 2019 23:34
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
@yoshuawuyts yoshuawuyts changed the title init write_fmt Add Write::write_fmt Oct 13, 2019
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
Copy link
Copy Markdown
Member

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@yoshuawuyts yoshuawuyts merged commit 33da049 into master Oct 13, 2019
@yoshuawuyts yoshuawuyts deleted the missing-write-methods branch October 13, 2019 17:53
@yoshuawuyts yoshuawuyts added this to the 0.99.10 milestone Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[tracking] fmt

2 participants