Log request and response headers#592
Conversation
There was a problem hiding this comment.
Possibly need eventids or something more than just a string
|
I thought it was best to log the headers and such closer to when they are actually read and written but I suppose when the HttpContext was created/disposed is good enough. I'll close this PR and open a new one in Hosting and remove the logging of headers in WebListener. |
|
@davidfowl I think it would be a good idea to expose a connection and request ID via the IHttpConnectionFeature and IHttpRequestFeature respectively. This should make it easier to correlate logs from different layers. I can open issues in Abstractions and Kestrel if you agree. |
|
|
|
I expect we'll need ConnectionId at some point. We already have IHttpRequestIdentifierFeature for request id. I agree that it would make correlation easier if the Kestrel implemented IHttpRequestIdentifierFeature. WebListener does. |
Item 2 of #4.
cc @CesarBS @halter73