Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Reduce closure allocation#287

Closed
benaadams wants to merge 3 commits into
aspnet:devfrom
benaadams:remove-closures
Closed

Reduce closure allocation#287
benaadams wants to merge 3 commits into
aspnet:devfrom
benaadams:remove-closures

Conversation

@benaadams

Copy link
Copy Markdown
Contributor

Removes a couple closure allocations identified in #286

@benaadams

Copy link
Copy Markdown
Contributor Author

Still 15 closures capturing via heap vs 28 previously; but number of variables in remaining ones is reduced.

Also most allocating delegates changed to non-allocating lamda expressions.

@benaadams

Copy link
Copy Markdown
Contributor Author

2002 requests before

img

2004 requests after

img

@benaadams

Copy link
Copy Markdown
Contributor Author

Needs to go further; some of the closures remaining are too heavy...

@benaadams

Copy link
Copy Markdown
Contributor Author

Next iteration for 2005 requests

allocs

Need to clean up names before I add commit

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert that

@benaadams benaadams changed the title Don't allocate closures Reduce closure allocation Oct 27, 2015
@benaadams

Copy link
Copy Markdown
Contributor Author

No sure about this.

@benaadams benaadams closed this Oct 27, 2015
@benaadams benaadams deleted the remove-closures branch November 6, 2015 07:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants