Refactored to use the fields from the HttpMethods class by mikaelm12 · Pull Request #1128 · aspnet/KestrelHttpServer

mikaelm12 · 2016-09-28T18:10:34Z

dnfclas · 2016-09-28T18:10:37Z

Hi @mikaelm12, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

mikeharder · 2016-09-28T18:15:00Z

-        [InlineData("PUT / HTTP/1.1", ' ', true, MemoryPoolIteratorExtensions.HttpPutMethod)]
-        [InlineData("OPTIONS / HTTP/1.1", ' ', true, MemoryPoolIteratorExtensions.HttpOptionsMethod)]
-        [InlineData("TRACE / HTTP/1.1", ' ', true, MemoryPoolIteratorExtensions.HttpTraceMethod)]
+        [InlineData("CONNECT / HTTP/1.1", ' ', true,"CONNECT")]


Any reason to hardcode "CONNECT" rather than using HttpMethods.Connect, as is done in the product code?

Can't use HttpMethods.Connect here because its not a const.

Fix the missing space though.

mikeharder · 2016-09-28T18:22:32Z

            if ((value & _mask4Chars) == _httpGetMethodLong)
            {
-                knownMethod = HttpGetMethod;
+                knownMethod = HttpMethods.Get;


Might be a tiny performance degradation since the value is changing from const to static readonly. Is there a reason the properties on HttpMethods are static readonly rather than const? I see the HttpMethods type is new for 1.1, so we should be able to change the properties to const now. After 1.1 ships it would be a breaking change.

I don't see any possible way the value of these properties would change in the future, so const should be safe.

aspnet/HttpAbstractions#712 (comment)

I doubt the performance will degrade

mikeharder · 2016-09-28T18:23:26Z

    {
        private static readonly Encoding _utf8 = Encoding.UTF8;

-        public const string HttpConnectMethod = "CONNECT";


Are breaking changes to public APIs on internal types allowed in 1.1?

It's in an "Internal" namespace.

halter73 · 2016-09-28T18:27:32Z

    {
        private static readonly Encoding _utf8 = Encoding.UTF8;

-        public const string HttpConnectMethod = "CONNECT";


It's in an "Internal" namespace.

halter73 · 2016-09-28T18:28:21Z

            if ((value & _mask4Chars) == _httpGetMethodLong)
            {
-                knownMethod = HttpGetMethod;
+                knownMethod = HttpMethods.Get;


aspnet/HttpAbstractions#712 (comment)

halter73 · 2016-09-28T18:29:57Z

@mikaelm12 You know how to run the plaintext benchmarks, right? I really don't expect this change will make any difference, but it's easy enough to test using @mikeharder's BenchmarksDriver.

davidfowl · 2016-09-28T18:33:10Z

-        [InlineData("PUT / HTTP/1.1", ' ', true, MemoryPoolIteratorExtensions.HttpPutMethod)]
-        [InlineData("OPTIONS / HTTP/1.1", ' ', true, MemoryPoolIteratorExtensions.HttpOptionsMethod)]
-        [InlineData("TRACE / HTTP/1.1", ' ', true, MemoryPoolIteratorExtensions.HttpTraceMethod)]
+        [InlineData("CONNECT / HTTP/1.1", ' ', true,"CONNECT")]


Could use MemberData but meh. We could have a second set of tests that verify reference equality.

@davidfowl Already do https://github.com/aspnet/KestrelHttpServer/blob/dev/test/Microsoft.AspNetCore.Server.KestrelTests/MemoryPoolIteratorTests.cs#L497-L518

Tratcher · 2016-09-28T22:26:11Z

      "type": "build"
-    }
+    },
+    "Microsoft.AspNetCore.Http.Abstractions": "1.1.0-*"


Hmmmmm, this is a new dependency? Doesn't this come in transitively already?

Yeah, it should be coming from Microsoft.AspNetCore.Hosting transitively.

muratg

👍

Refactored to use the fields from the HttpMethods class

ec12765

dnfclas added the cla-already-signed label Sep 28, 2016

mikeharder suggested changes Sep 28, 2016

View reviewed changes

halter73 approved these changes Sep 28, 2016

View reviewed changes

davidfowl reviewed Sep 28, 2016

View reviewed changes

cesarblum approved these changes Sep 28, 2016

View reviewed changes

Tratcher reviewed Sep 28, 2016

View reviewed changes

Reacting to PR comments

618b9e7

muratg approved these changes Sep 29, 2016

View reviewed changes

mikaelm12 merged commit 12adc7d into dev Sep 29, 2016

mikaelm12 deleted the mikaelm12/UseHttpMethodsConstants branch September 29, 2016 19:20

Uh oh!

Conversation

mikaelm12 commented Sep 28, 2016

Uh oh!

dnfclas commented Sep 28, 2016

Uh oh!

mikeharder Sep 28, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikeharder Sep 28, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

halter73 commented Sep 28, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

muratg left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

mikeharder Sep 28, 2016 •

edited

Loading

mikeharder Sep 28, 2016 •

edited

Loading