This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Renamed HttpMethod class to HttpMethods to avoid conflicts#714
Merged
Conversation
dougbu
approved these changes
Sep 27, 2016
dougbu
left a comment
Contributor
There was a problem hiding this comment.
since CI is broken. Probably want to get sign-off eventually from someone who lives in HtmlAbstractions but don't wait for that.
Member
|
Wait at least a few minutes for @muratg |
|
I don' think this is really necessary but @davidfowl really wanted to get this in.
|
Contributor
|
Is a Hosting PR ready to avoid breaking the CI again? |
Member
|
Hosting won't break, the prior change there was just to use a fully qualified name. |
Contributor
|
@Tratcher ah right. Could still revert the prior Hosting change to clean the code up again. |
Contributor
Author
Member
|
Yes please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So the name
HttpMethodcaused conflicts in the Hosting and BasicMiddleware repos because ofSystem.Net.HttpMethodHttpMethod' is an ambiguous reference between 'Microsoft.AspNetCore.Http.HttpMethod' and 'System.Net.Http.HttpMethodThis is a rename from
HttpMethodtoHttpMethods@muratg @Tratcher @davidfowl @dougbu