This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Merged
Conversation
Contributor
There was a problem hiding this comment.
Can we add a doc comment to this, perhaps warning that it's for testing scenarios only?
Contributor
There was a problem hiding this comment.
(And add a doc comment to the other Add() method while you're at it? 😄
Contributor
Author
There was a problem hiding this comment.
Sure. Btw, the Add overload with 2 arguments is just on this implementation. Most users will use configuration through IConfiguration which doesn't expose the overload
Contributor
There was a problem hiding this comment.
Ah I see, that's good to know. Good to document anyway 😄
Contributor
Author
|
Documented |
Contributor
There was a problem hiding this comment.
And all sentences with periods (summary, params, returns, etc.).
Contributor
Author
|
Updated with magic doc ref |
Contributor
|
|
!78b14b0 to
10ed680
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Eilon, in response to your comment here:
Couldn't move to an internal namespace because it is just a method. Also, moving it to an extension method would be strange because this method needs access to private fields.