feat: build event protocol local backend #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
f0rmiga
referenced
this pull request
Sep 18, 2021
otherwise it runs the prettier check on commit messages and finds no files
alexeagle
reviewed
Sep 18, 2021
Signed-off-by: Thulio Ferraz Assis <[email protected]>
Signed-off-by: Thulio Ferraz Assis <[email protected]>
alexeagle
approved these changes
Sep 24, 2021
|
|
||
| // Setup sets up the gRPC server. | ||
| func (bb *besBackend) Setup(opts ...grpc.ServerOption) error { | ||
| lis, err := bb.netListen("tcp", "127.0.0.1:0") |
Contributor
Author
There was a problem hiding this comment.
In UNIX, it means the port will be determined by the OS. It's a way of getting a random available port. In CLIs like this, we don't know the environment it will be executed, therefore, we don't want to pick a static port.
Contributor
Author
There was a problem hiding this comment.
Also, there's a latency in releasing the resources used by the previous run. Asking for a port from the OS makes it much faster between the CLI executions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a local gRPC service for the Build Event Protocol events. It listens on a random free port provided by the OS on localhost, which gets passed to the
bazel buildcommand.Test plan
Check the unit tests with subscribers and assert the test logic is correct.