Fix dehumanize to handle decimal fractions#1257
Open
rstar327 wants to merge 2 commits intoarrow-py:masterfrom
Open
Fix dehumanize to handle decimal fractions#1257rstar327 wants to merge 2 commits intoarrow-py:masterfrom
rstar327 wants to merge 2 commits intoarrow-py:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1257 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2315 2315
Branches 358 358
=========================================
Hits 2315 2315 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
toxormake testto find out!).tox -e lintormake lintto find out!).masterbranch.Description of Changes
Closes: #1237
dehumanize()currently only matches integer values in time strings, so inputs like"3.5 hours ago"are parsed incorrectly — the decimal portion is silently ignored, treating3.5as3.This PR updates the number matching regex to support decimal fractions using either
.or,as the decimal separator, and parses values asfloatinstead ofint:Example:
Tests added:
.separator)"2 days 3.5 hours ago")"3,5 hours ago")"in 1.5 hours")All 1909 tests pass with 99.93% coverage.