dos: strip volume specifier in getpacketinfo#801
Open
bsek wants to merge 1 commit into
Open
Conversation
Strip the volume/assign specifier before handing the name to the filesystem handler. GetDeviceProc() resolves the prefix to the correct handler + base lock, and the handler expects the remaining relative path - not the original name with a ':' still in it. Lock() in lock.c does the same. Without this, handlers whose path parser treats ':' as a "reset to root" marker (e.g. fat) end up searching the wrong directory and returning OBJECT_NOT_FOUND.
Member
|
Need to confirm if this behaviour is correct against amigaos. |
Contributor
|
If that's of any help, I created a "replacement" header which allows compiling cunit tests for AmigaOS. This way the same test can be added to AROS and be used to verify behavior with AmigaOS: https://github.com/deadwood2/AROS/blob/master/developer/debug/test/test-util.h |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strip the volume/assign specifier before handing the name to the filesystem handler. GetDeviceProc() resolves the prefix to the correct handler + base lock, and the handler expects the remaining relative path - not the original name with a ':' still in it.
Without this, handlers whose path parser treats ':' as a "reset to root" marker (at least the fat handler) end up searching the wrong directory and returning OBJECT_NOT_FOUND.