Rework SIMPLE-VECTOR implementation using openjdk8 facilities#624
Closed
easye wants to merge 18 commits into
Closed
Rework SIMPLE-VECTOR implementation using openjdk8 facilities#624easye wants to merge 18 commits into
easye wants to merge 18 commits into
Conversation
(INCOMPLETE) Start of exploration on simplifying and improving support for sequences, vectors, and arrays by using generics and functions shipped as part of openjdk8. Goals: 1) Simplify class structure with parameterized types 2) Use openjdk8 methods like Arrays.fill(), sort() et. al. 3) Reduce memory use for "oversized" buffers 4) Optimize speed of basic operations TODO need some benchmarks to test before/after
429bc97 to
b4abe8d
Compare
INCOMPLETE: after finishing implementation, needs to be wired into MAKE-ARRAY to be useful.
Collaborator
Author
|
*** Use of generics doesn't seem to help implementation BasicVectorBuffer
Superseded by #624 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(INCOMPLETE) Start of exploration on simplying and improving support for sequences, vectors, and arrays by using generics and functions shipped as part of openjdk8.
Goals:
Simplify class structure with parametertized types
Use openjdk8 methods like Arrays.fill(), sort() et. al.
Reduce memory use for "oversized" buffers
Optimize speed of basic operations
TODO need some benchmarks to test before/after