#1".." reader for more complicated java expressions, using javaparser#52
Closed
alanruttenberg wants to merge 3 commits into
Closed
#1".." reader for more complicated java expressions, using javaparser#52alanruttenberg wants to merge 3 commits into
alanruttenberg wants to merge 3 commits into
Conversation
Collaborator
|
I'll merge this work based on javaparser, but have doubts that this will work on Java 6 (but who knows). If we have problems on non-Java 8, we will need to conditionalize its usage in JSS based on whether the javaparser jar can be loaded, as a lot of the other contribs depend on JSS. |
Collaborator
|
I had to refactor the JAVAPARSER and JSS systems to rationalize load behavior 64203af, otherwise loading JSS was failing for me. In addition, you are missing the declarations for REPLACE-ALL and TREE-REPLACE in the javaparser code, so it doesn't work for other users at the moment. |
Collaborator
Author
|
Ok. I will fix in my next patch. Unfortunately I can't do that until
Monday, I expect, as I'm out of town heading to an informal college reunion.
…On Fri, Jun 9, 2017 at 4:57 AM Mark Evenson ***@***.***> wrote:
I had to refactor the JAVAPARSER and JSS systems to rationalize load
behavior 64203af
<64203af>,
otherwise loading JSS was failing for me.
In addition, you are missing the declarations for REPLACE-ALL and
TREE-REPLACE in the javaparser code, so it doesn't work for other users at
the moment.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#52 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAOxDsY9Y4R1WcLxaWFUMEucFr_wSGkwks5sCQkIgaJpZM4N0tbp>
.
|
Collaborator
Author
|
@alanruttenberg sez:
Are you sure the dependency wasn't in the tests? I deliberately wrote this
so that it wouldn't be loaded unless used. Not so keen on redefining a
function in a second system .
@easye replies:
There were a couple of dependency problems, that looked best resolved by pushing their declarations to ASDF. If there is a better solution, please let me know, but I'm trying to make a release here.
In any event, the tests don't run, which needs to be fixed.
|
svn2github
pushed a commit
to svn2github/abcl
that referenced
this pull request
Jun 9, 2017
(Alan Ruttenberg) From <armedbear/abcl@291289e> Part of merge <armedbear/abcl#52>. git-svn-id: http://abcl.org/svn@15062 1c010e3e-69d0-11dd-93a8-456734b0d56f
svn2github
pushed a commit
to svn2github/abcl
that referenced
this pull request
Jun 9, 2017
(Alan Ruttenberg) From <armedbear/abcl@987c18f>. Part of merge <armedbear/abcl#52>. git-svn-id: http://abcl.org/svn@15063 1c010e3e-69d0-11dd-93a8-456734b0d56f
svn2github
pushed a commit
to svn2github/abcl
that referenced
this pull request
Jun 9, 2017
(Alan Ruttenberg) From <armedbear/abcl@155db3e>. Part of merge <armedbear/abcl#52>. git-svn-id: http://abcl.org/svn@15064 1c010e3e-69d0-11dd-93a8-456734b0d56f
Collaborator
|
Further fixes, including "stacking" the JAVAPARSER READ-INVOKE definitions in 80f8222 |
slyrus
pushed a commit
to slyrus/abcl
that referenced
this pull request
Nov 16, 2019
(Alan Ruttenberg) From <armedbear/abcl@291289e> Part of merge <armedbear/abcl#52>. git-svn-id: http://abcl.org/svn/trunk/abcl@15062 1c010e3e-69d0-11dd-93a8-456734b0d56f
slyrus
pushed a commit
to slyrus/abcl
that referenced
this pull request
Nov 16, 2019
(Alan Ruttenberg) From <armedbear/abcl@987c18f>. Part of merge <armedbear/abcl#52>. git-svn-id: http://abcl.org/svn/trunk/abcl@15063 1c010e3e-69d0-11dd-93a8-456734b0d56f
slyrus
pushed a commit
to slyrus/abcl
that referenced
this pull request
Nov 16, 2019
(Alan Ruttenberg) From <armedbear/abcl@155db3e>. Part of merge <armedbear/abcl#52>. git-svn-id: http://abcl.org/svn/trunk/abcl@15064 1c010e3e-69d0-11dd-93a8-456734b0d56f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the base class for using the java parser library. JSS will use this (in another commit) to enable writing more complicated java expressions using #1"..." e.g.
(#1"new ByteBuddy().subclass(Object.class,t)
.method(ElementMatchers.named("toString"))
.intercept(FixedValue.value("Hello World!"))
.make()
.load(getClass().getClassLoader())
.getLoaded()" )