Updates to jss/javaparser#479
Conversation
…able. Have invoke load javaparser first time armedbear#1 is used.
There was a problem hiding this comment.
I haven't had time to test this yet. It would be best to add running the javaparser test suite as part of the Github CI, but that requires somewhat specialized knowledge that I don't really expect that others have. Although adding another line to run the JSS tests is pretty easy, learning Github CI to the point of being able to re-run tests without another merge request could be somewhat frustating. I will try to get the cycles to make the changes, observe the results, and likely merge this in the next day unless someone reports problems.
| @@ -1,3 +1,4 @@ | |||
| (in-package :asdf) | |||
There was a problem hiding this comment.
No need to use in-package: asdf systems need to be canonically processed by the generic methods which encapsulate the internal ASDF machinery for everything to always work properly. eval/loading the source unit can be an shortcut in debugging sometimes but there are enough weird edge cases that one should not get in the habit of trusting such a process as the final result.
There was a problem hiding this comment.
Don't like relying on magic. I ran and fixed the tests.
|
@alanruttenberg Please don't close the ticket until the associated pull makes it in, as it will confuse people. Yes, it is fixed for you, but not with respect to the dev tree. And thanks as always for the love (and JSS, which seems to be getting some wider use these days)! |
|
I closed one of 3 after I put the actionable issues in the other two tickets. Glad it's merged now. |
|
My mistake. Apologies for the false statment on my part. |
Update to javaparser 3.24.2. Fix tests. Fix typo: ignoreable -> ignorable. Have invoke load javaparser first time #1 is used. Fixes #475 #477 #478