Bits per pixel#51
Closed
bhill-slac wants to merge 12 commits into
Closed
Conversation
Merging from areaDetector:master
…ds_slac Merging in changes from Mark's ADCore master
Merging pcds_slac into master branch
… pcds_slac Updating from github
Bringing in updates from pcds_slac branch
Merging in recent work from Mark's githum ADCore master branch
Member
|
Hi Bruce, Thanks also for this Pull Request. Please see my practical comment on #50 regarding cleaning the history of the branch into a single (or maybe two in this case?) commits. In the changes here I find there are a mix of tabs and spaces. We generally stick with spaces in areaDetector now (there is a history of mixing which we would like to clean). Would you mind getting rid of the tabs, please? It can be done in a single additional commit and there is no need to re-issue the Pull Request then. Cheers, |
Member
|
Sorry, I only meant to comment, not to close the pull request, so I have reopened it. |
Closed
Member
|
I reopened this by mistake, rather than #52. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for BitsPerPixel and BytesPerPixel PV's in ADBase